Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show info message instead of config for containers that are not group #12236

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Feb 2, 2024

Description

Until we can render the config panel for the containers (that is not Group) based on the json schemas, we show an information message in the Innhold accordion.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3a7d5d) 86.41% compared to head (2105a8b) 86.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12236   +/-   ##
=======================================
  Coverage   86.41%   86.42%           
=======================================
  Files        1188     1188           
  Lines       18045    18049    +4     
  Branches     2290     2292    +2     
=======================================
+ Hits        15594    15598    +4     
  Misses       2164     2164           
  Partials      287      287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren force-pushed the disable-editing-for-containers-not-being-group branch from 1c2bd0f to ffd7f17 Compare February 2, 2024 08:14
@standeren standeren marked this pull request as ready for review February 2, 2024 08:48
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@standeren standeren merged commit 008fd97 into main Feb 2, 2024
12 checks passed
@standeren standeren deleted the disable-editing-for-containers-not-being-group branch February 2, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant